Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modify warning message #28514

Closed
wants to merge 1 commit into from
Closed

Modify warning message #28514

wants to merge 1 commit into from

Conversation

jiggag
Copy link
Contributor

@jiggag jiggag commented Apr 3, 2020

Summary

Modify deprecation warning message for AccessibilityInfo.fetch

Changelog

[Internal] [Changed] - Modify deprecation warning message for AccessibilityInfo.fetch

Test Plan

Try using AccessibilityInfo.fetch and check log

@facebook-github-bot
Copy link
Contributor

Hi @jiggag!

Thank you for your pull request and welcome to our community.We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file.

In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@analysis-bot
Copy link

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 6,607,449 0
android hermes armeabi-v7a 6,284,296 -11
android hermes x86 6,948,215 17
android hermes x86_64 6,878,678 -4
android jsc arm64-v8a 8,915,722 1
android jsc armeabi-v7a 8,555,913 -11
android jsc x86 8,740,503 0
android jsc x86_64 9,317,219 -21

Base commit: 3a11f05

@analysis-bot
Copy link

analysis-bot commented Apr 3, 2020 •
edited

Platform Engine Arch Size (bytes) Diff
ios - universal 965552 n/a

Base commit: 83fee73

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 3, 2020
@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

facebook-github-bot
facebook-github-bot reviewed Apr 3, 2020
View reviewed changes
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@TheSavior has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@react-native-bot
Copy link
Collaborator

This pull request was successfully merged by @jiggag in caa7829.

When will my fix make it into a release? | Upcoming Releases

@react-native-bot react-native-bot added the Merged This PR has been merged. label Apr 4, 2020
sasurau4 pushed a commit to sasurau4/react-native that referenced this pull request Apr 15, 2020
@jiggag @sasurau4
Modify warning message (facebook#28514)
2348ec5 
Summary:
Modify deprecation warning message for `AccessibilityInfo.fetch`

- https://reactnative.dev/docs/accessibilityinfo#isscreenreaderenabled
- facebook@523ab83

## Changelog

[Internal] [Changed] - Modify deprecation warning message for `AccessibilityInfo.fetch`
Pull Request resolved: facebook#28514

Test Plan: Try using `AccessibilityInfo.fetch` and check log

Reviewed By: cpojer

Differential Revision: D20850223

Pulled By: TheSavior

fbshipit-source-id: e21bb20b7a02d9f2ed6e27e2bfecbac0aebf9e09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@facebook-github-bot facebook-github-bot facebook-github-bot left review comments

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jiggag @facebook-github-bot @analysis-bot @react-native-bot